Skip to content

Require mypy < 1.7.0#91

Closed
CoolCat467 wants to merge 1 commit into
python-trio:masterfrom
CoolCat467:require-mypy-lessthan-1.7.0
Closed

Require mypy < 1.7.0#91
CoolCat467 wants to merge 1 commit into
python-trio:masterfrom
CoolCat467:require-mypy-lessthan-1.7.0

Conversation

@CoolCat467

Copy link
Copy Markdown
Member

As per #90, this PR makes the project require mypy < 1.7.0

@jakkdl

jakkdl commented Nov 22, 2023

Copy link
Copy Markdown
Member

the failure is from this package not being updated since before trio 0.23, and we having made small changes to the API since. Dirty fix would be to add a requirement for trio==0.xx.yy - but if we're to release that we really want a warning somewhere that this package is deprecated.

@jakkdl jakkdl changed the title Requre mypy < 1.7.0 Require mypy < 1.7.0 Nov 22, 2023
@TeamSpen210

Copy link
Copy Markdown
Contributor

I don't think we can fix this via metadata changes. Pip will just go back in versions and use an earlier version of trio-typing that is "compatible".

@jakkdl

jakkdl commented Nov 23, 2023

Copy link
Copy Markdown
Member

oh right, derp.

@oremanj

oremanj commented Dec 1, 2023

Copy link
Copy Markdown
Member

Closed in favor of #92 which more properly supports mypy 1.7.

@oremanj oremanj closed this Dec 1, 2023
@CoolCat467 CoolCat467 deleted the require-mypy-lessthan-1.7.0 branch December 1, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants